Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set otlp-proto-grpc as the default metrics exporter for auto-instrumentation #1127

Merged

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Jun 9, 2022

Description

In opentelemetry-distro, set otlp-grpc-proto as the default value for OTLP_METRICS_EXPORTER. This make it the default when using opentelemetry-instrument, similar to tracing.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Install the change in local venv and ran:

$ opentelemetry-instrument ipython
Python 3.9.12 (main, Mar 24 2022, 13:02:21)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.24.1 -- An enhanced Interactive Python. Type '?' for help.

In [1]: from opentelemetry import metrics

In [2]: metrics.get_meter_provider()._sdk_config.metric_readers[0]._exporter
Out[2]: <opentelemetry.exporter.otlp.proto.grpc.metric_exporter.OTLPMetricExporter at 0x7fb4387ecdf0>

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

@aabmass aabmass requested a review from a team June 9, 2022 20:41
@aabmass aabmass force-pushed the otlp-default-metrics-exporter branch from 6cc9f2e to 2b59641 Compare June 9, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants