Skip to content

Commit

Permalink
Change meta data service timeout to 200ms (#2387)
Browse files Browse the repository at this point in the history
  • Loading branch information
lzchen authored Apr 5, 2024
1 parent 805c72c commit 85ca0a6
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 4 deletions.
15 changes: 15 additions & 0 deletions resource/opentelemetry-resource-detector-azure/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased

- Change meta data service timeout to 200ms
([#2387](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2387))

## Version 0.1.2 (2024-01-25)

- Initial CHANGELOG.md entry
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,8 @@ def _get_azure_vm_metadata():
request = Request(_AZURE_VM_METADATA_ENDPOINT)
request.add_header("Metadata", "True")
try:
# TODO: Changed to 4s to fit into OTel SDK's 5 second timeout.
# Lengthen or allow user input if issue is resolved.
# See https://github.com/open-telemetry/opentelemetry-python/issues/3644
with urlopen(request, timeout=4) as response:
# VM metadata service should not take more than 200ms on success case
with urlopen(request, timeout=0.2) as response:
return loads(response.read())
except URLError:
# Not on Azure VM
Expand Down

0 comments on commit 85ca0a6

Please sign in to comment.