Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is knowing that the metric values are aggregated from raw measurements important? #188

Open
bogdandrutu opened this issue Jul 30, 2020 · 2 comments
Open

Is knowing that the metric values are aggregated from raw measurements important? #188

bogdandrutu opened this issue Jul 30, 2020 · 2 comments
Labels
release:after-ga Not required before GA release, and not going to work on before GA spec:metrics

Comments

@bogdandrutu
Copy link
Member

Currently there is a TODO in the metrics proto that needs a decision:

// TODO: Decide if knowing that the metric values are aggregated from raw measurements is important.
@bogdandrutu
Copy link
Member Author

In other words, in a Histogram/Summary the count represents the number of times the App recorded values.

@jmacd
Copy link
Contributor

jmacd commented Jul 30, 2020

I like the idea of narrowly defining this as whether the aggregation Count matches the number of input measurements.

@bogdandrutu bogdandrutu added the release:after-ga Not required before GA release, and not going to work on before GA label Jul 30, 2020
@jmacd jmacd mentioned this issue Jul 30, 2020
Closed
bogdandrutu added a commit to bogdandrutu/opentelemetry-proto that referenced this issue Aug 5, 2020
@bogdandrutu
Remove todos related to issues open-telemetry#188 and open-telemetry#189
acf12df 


Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit that referenced this issue Aug 6, 2020
@bogdandrutu
Remove todos related to issues #188 and #189 (#194)
f03768d 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@jmacd jmacd mentioned this issue Sep 22, 2020
Closed
@jmacd jmacd mentioned this issue Nov 12, 2020
Merged
@jmacd jmacd mentioned this issue Dec 18, 2020
Closed
@jmacd jmacd mentioned this issue Mar 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release:after-ga Not required before GA release, and not going to work on before GA spec:metrics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bogdandrutu @jmacd