-
Notifications
You must be signed in to change notification settings - Fork 206
refactor semantic conventions #1659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Align with how the spec advises SemConv should be organised, and break unstable semconvs out into their own directory. I played around with generating values as enums, but I could only get this to work if the output was in the same file as the attributes (which would not work well with composer autoloading), so I've used <attribute>_VALUE_<name>, similar to what we have now except all in the same file.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1659 +/- ##
============================================
+ Coverage 68.64% 68.66% +0.02%
Complexity 2854 2854
============================================
Files 425 425
Lines 8699 8699
============================================
+ Hits 5971 5973 +2
+ Misses 2728 2726 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Align with how the spec advises SemConv should be organised, and break incubating (stable + unstable) semconvs out into their own directory.
I played around with generating values as enums, but I could only get this to work if the output was in the same file as the attributes (which would not work well with composer autoloading), so I've used
<attribute>_VALUE_<name>
, similar to what we have now except all in the same file as the attributes.Discussion: