Mago analysis

[bobstrecansky]

We need to perform an analysis on how Mago is going since it's been enabled in our repos for a while.

[Devansh1093]

I’d like to help with the Mago analysis.

[bobstrecansky]

By all means @Devansh1093 - feel free to look - Mago has been enabled for recent PRs, so you should be able to review.

[Devansh1093]

Hi , I have reviewed many PRs since Mago was introduced in #1913.
For analysis , I have only considered PRs by contributors and ignored the renovate Bot ones.
Table

PR	Type	Mago Findings	Observation
#1929	Feature	21 errors, 19 warnings, 10 notices	Initial baseline after Mago introduction
#1933	Test	21 errors, 19 warnings, 10 notices	Findings reported in SDK/configuration files rather than test files
#1937	CI	21 errors, 19 warnings, 10 notices	Findings unrelated to build matrix changes
#1939	Feature	21 errors, 19 warnings, 10 notices	Findings mainly in Registry, Configuration, and Symfony files
#1944	Maintenance	21 errors, 19 warnings, 10 notices	Findings reported despite maintenance-only changes
#1966	CI/Fix	21 errors, 19 warnings, 10 notices	Findings mostly outside modified files
#1975	Feature	21 errors, 19 warnings, 10 notices	Findings largely unrelated to baggage parser changes
#1976	Test	21 errors, 19 warnings, 10 notices	Similar repository-wide findings as #1975
#1980	Maintenance	21 errors, 19 warnings, 10 notices	README-only change, but findings reported in PHP source files

Observations

• The workflow is configured as non blocking.
• Mago consistently reported 21 errors, 19 warnings and 10 notices.

Conclusion

Mago works as a repository wide code monitor rather than a PR review tool. It successfully surfaces existing code quality issues, but many reported findings are unrelated to the files modified by the PR.

[bobstrecansky]

@Devansh1093 - this just appears to be AI generated. I would suspect a new tool like this to post consistent warnings, because those issues haven't been addressed in the repos.

[Devansh1093]

Okay, I will try to come up with a new tool. I just used AI to summarize the analysis. If you want the analysis without the use of any AI and I can do that.

[bobstrecansky]

Please and thank you!

[bobstrecansky]

Let us know when you've completed this!

[Devansh1093]

I am not able to come with a new tool. You can assign this task to someone else. Thank you !