KIND::CONSUMER instrumentation implemented #307
Conversation
…ER and KIND_CONSUMER
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
============================================
- Coverage 85.87% 80.41% -5.46%
+ Complexity 1081 592 -489
============================================
Files 73 43 -30
Lines 4480 2211 -2269
============================================
- Hits 3847 1778 -2069
+ Misses 633 433 -200
Flags with carried forward coverage won't be shown. Click here to find out more. see 56 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| return new LegacyInMemoryTransport(); | ||
| } | ||
|
|
||
| protected function getReceiver() |
There was a problem hiding this comment.
is this different enough from getTransport to require a method? It doesn't return a receiver but a transport...
There was a problem hiding this comment.
@RichardChukwu have you had any time to look further into this?
There was a problem hiding this comment.
Hey @ChrisLightfootWild, thanks for asking.
Not really, I'll appreciate any assistance please
| $builder = $instrumentation | ||
| ->tracer() | ||
| ->spanBuilder(\sprintf('DISPATCH %s', $messageClass)) | ||
| ->setSpanKind(SpanKind::KIND_PRODUCER) | ||
| ->spanBuilder(\sprintf('publish %s', $messageClass)) |
There was a problem hiding this comment.
The span types and names should be consistent with the spec here:
https://opentelemetry.io/docs/specs/semconv/messaging/messaging-spans/#span-kind
But it's kind of confusing TBH, it mentions both "publish" and "send", in the example it gives publish shop.orders, but then it doesn't give publish in operation type or span kind. 🤯
@brettmc can you clarify the spec wording here maybe?
Fixes #1314
Related #304
-Added the "consume" operation with SpanKind::KIND_CONSUMER for receiving messages.
-Updated span names to use publish, send, and consume as per the spec, ensuring naming consistency for operations.
-Instrumented the SenderInterface for both sending and receiving spans, with the appropriate SpanKind (producer for sending and consumer for receiving).