Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set replicas to default value #814

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Set replicas to default value #814

merged 4 commits into from
Apr 12, 2022

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay p.loffay@gmail.com

Follow up for #798

@pavolloffay
Set replicas to default value
bfa914e 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay pavolloffay requested a review from a team April 7, 2022 11:27
jpkrohling
jpkrohling approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wonder if this is a new behavior brought in by one of our dependencies, or if we always had this bug and nobody ever complained, which seems unlikely, as I doubt all our users are setting the number of replicas in their CRs.

apis/v1alpha1/opentelemetrycollector_webhook.go Show resolved Hide resolved
apis/v1alpha1/opentelemetrycollector_webhook_test.go Outdated Show resolved Hide resolved
@pavolloffay
Fix
690166a 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay
Fix
893393b 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay
Fix
215a1e7 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@jpkrohling jpkrohling merged commit b77c89d into open-telemetry:main Apr 12, 2022
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@pavolloffay
Set replicas to default value (open-telemetry#814)
9ebf5c7 
* Set replicas to default value

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Fix

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Fix

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Fix

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

@frzifus frzifus frzifus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavolloffay @jpkrohling @frzifus