Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nodejs and python image defaulting and upgrade #607

Merged

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Dec 6, 2021

Signed-off-by: Pavol Loffay p.loffay@gmail.com

Defaulting and upgrading for Java auto-instrumentation already exists.

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay pavolloffay requested review from a team and tigrannajaryan December 6, 2021 16:25
@pavolloffay
Copy link
Member Author

@VineethReddy02 would you like to review?

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay pavolloffay changed the title Add support nodejs and python image defaulting and upgrade Add support for nodejs and python image defaulting and upgrade Dec 6, 2021
@pavolloffay pavolloffay closed this Dec 7, 2021
@pavolloffay pavolloffay reopened this Dec 7, 2021
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay
Copy link
Member Author

@VineethReddy02 friendly ping. Please review this one, it finishes the feature parity for all auto-instrumentations.

Copy link
Contributor

@VineethReddy02 VineethReddy02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @pavolloffay
LGTM!

cc @jpkrohling for the final review (totally optional Juraci, if you are occupied)!

inst.Annotations[v1alpha1.AnnotationDefaultAutoInstrumentationNodeJS] = u.DefaultAutoInstrNodeJS
}
}
autoInstNodePython := inst.Annotations[v1alpha1.AnnotationDefaultAutoInstrumentationPython]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoInstNodePython -> autoInstPython node as python suffix is bit confusing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch this is a typo. fixed

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@jpkrohling
Copy link
Member

cc @jpkrohling for the final review

Your approval is enough. Merging.

@jpkrohling jpkrohling merged commit 53b62ca into open-telemetry:main Dec 15, 2021
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
…telemetry#607)

* Add support nodejs and python image defaulting and upgrade

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Fix

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Fix

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Fix

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Fix

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Fix  typo

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants