Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use operator image from GHCR #536

Merged
merged 3 commits into from
Nov 12, 2021
Merged

Use operator image from GHCR #536

merged 3 commits into from
Nov 12, 2021

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Nov 11, 2021 •
edited
Loading

@pavolloffay
Use operator image from GHCR
00691a5 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay
Fix
809aa5d 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay
Fix
b3bd30d 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay pavolloffay requested review from a team and codeboten November 11, 2021 15:32
VineethReddy02
VineethReddy02 approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@VineethReddy02 VineethReddy02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cc @jpkrohling

jpkrohling
jpkrohling approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those the only places we use Quay?

@jpkrohling jpkrohling merged commit cf2e7e1 into open-telemetry:main Nov 12, 2021
@pavolloffay
Copy link
Member Author

The target allocator is hosted on quay.

@pavolloffay pavolloffay mentioned this pull request Nov 12, 2021
Closed
@jpkrohling
Copy link
Member

The next step is then to change it to also use GHCR.

@pavolloffay
Copy link
Member Author

I leave this for the maintainer of that component

shree007 pushed a commit to shree007/opentelemetry-operator that referenced this pull request Dec 12, 2021
@pavolloffay
Use operator image from GHCR (open-telemetry#536)
af7075a 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@pavolloffay
Use operator image from GHCR (open-telemetry#536)
caff92c 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VineethReddy02 VineethReddy02 VineethReddy02 approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

@codeboten codeboten Awaiting requested review from codeboten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavolloffay @jpkrohling @VineethReddy02