[clusterobservability] fix config for bundled collectors#5080
Open
jinja2 wants to merge 3 commits into
Open
Conversation
jinja2
changed the title
Contributor
E2E Test Results 40 files 273 suites 2h 24m 20s ⏱️ Results for commit 92fc794. ♻️ This comment has been updated with latest results. |
jinja2
force-pushed
the
clustobs-runnable
branch
7 times, most recently
from
ad20221 to
6be7270
Compare
jinja2
force-pushed
the
clustobs-runnable
branch
3 times, most recently
from
dade0ee to
d5ccd0e
Compare
…servability Follow-ups to the initial ClusterObservability framework so the generated agent and cluster collectors come up cleanly on stock distributions, plus a smoke e2e that exercises the pipelines end-to-end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Fixes for the bundled agent and cluster collectors generated from a ClusterObservability CR start cleanly on stock k8s.
getCollectorImageto swap anyopentelemetry-collectorimage for its-contribcounterpart (bundled configs use contrib-only components; main only special-cased the:0.0.0dev fallback).K8S_NODE_NAMEon the agent pod via the downward API so the bundledkubeletstatsreceiver'shttps://${env:K8S_NODE_NAME}:10250endpoint resolves.config.DistroProvider, and extract agent volumes/mounts into helper functions gated on it. No user-visible behavior change.checkClusterCollectorStatusnow reads the StatefulSet workload, so the CR no longer stays inPendingeven when the cluster collector is fully healthy. The CR was update to use STS in feat(clusterobservability): enable TargetAllocator support for cluster collectors #5139Link to tracking Issue(s):
Testing:
make e2e-clusterobservabilitychainsaw targetmake prepare-e2e-clusterobservabilityrunsadd-rbac-permissions-to-operator(opt-in kustomize patches) and bakes in--feature-gates=+operator.clusterobservabilityfor the duration of the e2e job.experimental: truewith matchingcontinue-on-error, so failures don't block other operator e2e jobs.serverTLSBootstrap;start-kindapproves the kubelet-serving CSRs so thekubeletstatsreceiver can verify the kubelet against the cluster CA.clusterobservability_test.gocover the image rewrite and distro-gated volumes/mounts.