Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate docs from CRD spec #505

Merged
merged 6 commits into from
Nov 11, 2021
Merged

Generate docs from CRD spec #505

merged 6 commits into from
Nov 11, 2021

Conversation

iblancasa
Copy link
Contributor

@iblancasa iblancasa commented Nov 4, 2021 •
edited by jpkrohling
Loading

Closes #325

Signed-off-by: Israel Blancas iblancas@redhat.com

@iblancasa
Generate docs from CRD spec. Closes open-telemetry#325
3b9e378 
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@iblancasa iblancasa requested review from a team and codeboten November 4, 2021 12:32
jpkrohling
jpkrohling approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@iblancasa
Apply changes suggested in CR
3ee5ce2 
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@iblancasa
Copy link
Contributor Author

iblancasa commented Nov 4, 2021 •
edited
Loading

I applied some changes. I think this is what you are suggesting, right? @jpkrohling

@iblancasa
Apply changes requested in CR
f166062 
Signed-off-by: Israel Blancas <iblancas@redhat.com>
jpkrohling
jpkrohling reviewed Nov 5, 2021
View reviewed changes
.github/workflows/continuous-integration.yaml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@paulfantom paulfantom mentioned this pull request Nov 9, 2021
Closed
roee88
roee88 reviewed Nov 10, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@iblancasa
Apply changes requested in CR
0b7794e 
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@iblancasa
Merge branch 'main' into feature/325
2f00dd9
@iblancasa
Update docs API and fix target name
ef409ba 
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@jpkrohling jpkrohling changed the title Generate docs from CRD spec. Closes #325 Generate docs from CRD spec Nov 11, 2021
@jpkrohling jpkrohling enabled auto-merge (squash) November 11, 2021 09:59
@jpkrohling jpkrohling merged commit f0818d7 into open-telemetry:main Nov 11, 2021
@iblancasa iblancasa deleted the feature/325 branch November 11, 2021 10:21
shree007 pushed a commit to shree007/opentelemetry-operator that referenced this pull request Dec 12, 2021
@iblancasa
Generate docs from CRD spec (open-telemetry#505)
af59a8e 
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@pavolloffay pavolloffay mentioned this pull request Feb 2, 2022
Closed
This was referenced Feb 2, 2023
Closed
Closed
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@iblancasa
Generate docs from CRD spec (open-telemetry#505)
4172a13 
Signed-off-by: Israel Blancas <iblancas@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roee88 roee88 roee88 left review comments

@pavolloffay pavolloffay pavolloffay approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

@codeboten codeboten Awaiting requested review from codeboten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate docs from CRD spec
4 participants
@iblancasa @jpkrohling @roee88 @pavolloffay