Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move otelcol api into api/otelcol #462

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Move otelcol api into api/otelcol #462

merged 1 commit into from
Oct 22, 2021

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay p.loffay@gmail.com

This is a preparation for #455

The instrumentation feature will be managed in a separate CR. Therefore it makes sense to create a subpackage for each CR. E.g.:

api/otelcol/v1alpha1
api/inst/v1alpha1

@pavolloffay
Move otelcol api into api/otelcol
bca7293 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay pavolloffay requested review from a team and codeboten October 19, 2021 10:48
@pavolloffay pavolloffay mentioned this pull request Oct 21, 2021
Merged
jpkrohling
jpkrohling approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You mentioned "inst" in the description: can we have a few proposals before settling on the short name? I think the package name can still be instrumentation, though. In my opinion, inst is closer to install than to instrumentation.

@jpkrohling jpkrohling merged commit a45ce3d into open-telemetry:main Oct 22, 2021
@pavolloffay
Copy link
Member Author

api/instrumentation/ sounds good to me. Another alternative is api/otelist which would align with otelcol and it as well matches the short name of the instrumentation feature. Let's discuss it on the instrumentation PR

@pavolloffay pavolloffay mentioned this pull request Oct 25, 2021
Merged
shree007 pushed a commit to shree007/opentelemetry-operator that referenced this pull request Dec 12, 2021
@pavolloffay
Move otelcol api into api/otelcol (open-telemetry#462)
6051600 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@pavolloffay
Move otelcol api into api/otelcol (open-telemetry#462)
d9b410a 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

@codeboten codeboten Awaiting requested review from codeboten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavolloffay @jpkrohling @anuraaga