-
Couldn't load subscription status.
- Fork 561
Propagate annotations of the OTelCol and TA custom resources to the TA deployment resource #4402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Propagate annotations of the OTelCol and TA custom resources to the TA deployment resource #4402
Conversation
|
Do you mind changing an existing e2e test and add an annotation? |
|
Sure, I'll take a look next week once I'm back in the office |
0f9c881 to
6301ee7
Compare
|
Added to E2E tests (both OTelCol and TA CR). The E2E test failed in the run before (targetallocator-metrics) was a time-out, succeeds when running locally (same k8s version) E2E test report files from running locallye2e-targetallocator.xml e2e-targetallocator-cr.xml I kindly request you to review again. Thanks in advance! |
6301ee7 to
1bb74b0
Compare
|
@swiatekm could you please review as well? |
|
Looks like you have some test failures @mikel-jason, can you have a look? |
1bb74b0 to
a76c8eb
Compare
|
Solved and rebased.
FYI I found out I can run the tests with opentelemetry-operator/CONTRIBUTING.md Lines 110 to 119 in 4cbac0f
|
Description:
Annotationsbut meansPodAnnotations. I just renamed it without any further change for backwards compatibility. Yet it would be debatable if it's the pod annotation which should be put on the pdb and netpol. That's a different topic though.Resolves: #4393
Testing:
go test ./internal/manifests/...succeeds. As the changes are limited to that package, I guessed it's enough to raise the PR and see the checks in the CI pipelines.kindclusterDocumentation: None