[chore] Don't check changelog links in CI #3424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblancasa
approved these changes
Nov 6, 2024
swiatekm
force-pushed
the
chore/changellg-check-links
branch
from
d4e4b91 to
a06b879
Compare
swiatekm
changed the title
iblancasa
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at some recent failures of the changelog workflow on PRs: https://github.com/open-telemetry/opentelemetry-operator/actions/workflows/changelog.yaml, I noticed the link check doesn't do anything useful. The changelog tool's preview command actually outputs the new changelog segment to stderr (and not stdout as the docs claim), so we're running markdown-link-check on some random chloggen output.
Furthermore, it doesn't even make sense to check this - what we should do instead is check changelog links during releases, or check links in all of our docs at different points. For now, I'm removing the blocker.