Fix upgrade testing #3364
Merged
Fix upgrade testing #3364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
commented
Oct 17, 2024
| @@ -56,7 +55,9 @@ func Test0_104_0Upgrade(t *testing.T) { | |||
| t.Errorf("expect err: nil but got: %v", err) | |||
| } | |||
| assert.EqualValues(t, | |||
| map[string]string{}, | |||
| map[string]string{ | |||
| "feature-gates": "-component.UseLocalHostAsDefaultHost", | |||
There was a problem hiding this comment.
this should be present in 104 but gone in 105 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes a bug in the upgrade testing that ran all the upgrades despite a version being set. This will now let us run each upgrades in isolation (future upgrades will not effect the current one.) i.e. a test for 0.9.0 would have to take 0.15.0 into account, this is no longer the case.