Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS support to auto-instrumentation #3338

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Add TLS support to auto-instrumentation #3338

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e8d00b
Add TLS support to auto-instrumentation
pavolloffay Oct 8, 2024
ed2db96
Fix
pavolloffay Oct 10, 2024
2849547
Fix
pavolloffay Oct 11, 2024
6bed105
More validation
pavolloffay Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
  • Loading branch information
@pavolloffay
pavolloffay committed Oct 11, 2024
commit 2849547c20e026772aff9c1dbfe07bfaf217e97e
3 changes: 2 additions & 1 deletion pkg/instrumentation/podmutator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,8 @@ func (pm *instPodMutator) Mutate(ctx context.Context, ns corev1.Namespace, pod c
return pod, err
}

if err = pm.validateInstrumentations(ctx, insts, pod.Namespace); err != nil {
if err = pm.validateInstrumentations(ctx, insts, ns.Name); err != nil {
logger.Error(err, "failed to validate instrumentations")
return pod, err
}

Expand Down
2 changes: 1 addition & 1 deletion tests/e2e-instrumentation/instrumentation-java-tls/00-install-collector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ spec:
processors:

exporters:
debug:
debug: {}

service:
pipelines:
Expand Down
Loading