apis/v1beta1: remove ComponentUseLocalHostAsDefaultHost feature gate #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzifus
commented
Oct 7, 2024
jaronoff97
reviewed
Oct 7, 2024
frzifus
force-pushed
the
remove_localhost_fg
branch
2 times, most recently
from
4abed7c
to
8b03377
Compare
frzifus
force-pushed
the
remove_localhost_fg
branch
2 times, most recently
from
c08913e
to
81b7cbb
Compare
jaronoff97
approved these changes
Oct 7, 2024
|
seems like theres a linter issue still and a few e2e tests failing, but the logic LGTM. |
frzifus
force-pushed
the
remove_localhost_fg
branch
4 times, most recently
from
55b41de
to
56279c8
Compare
frzifus
commented
Oct 7, 2024
tests/e2e-instrumentation/instrumentation-python-multicontainer/02-assert.yaml
Outdated
Show resolved
Hide resolved
frzifus
force-pushed
the
remove_localhost_fg
branch
from
5977990
to
b9c5e2c
Compare
jaronoff97
reviewed
Oct 8, 2024
jaronoff97
reviewed
Oct 8, 2024
| map[string]string{"feature-gates": "-component.UseLocalHostAsDefaultHost"}, | ||
| map[string]string{}, |
There was a problem hiding this comment.
shouldn't this still be true?
There was a problem hiding this comment.
maybe not if the test is running all the upgrades...
There was a problem hiding this comment.
y, I think the Problem is that the upgrade does not stop at 104.
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
frzifus
force-pushed
the
remove_localhost_fg
branch
from
b9c5e2c
to
2f26a0e
Compare
pavolloffay
reviewed
Oct 8, 2024
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
swiatekm
approved these changes
Oct 8, 2024
pavolloffay
reviewed
Oct 8, 2024
pavolloffay
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Needs rebase after #3333
Link to tracking Issue(s):
Testing:
Documentation: