Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controller for TargetAllocator CR #3275

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

swiatekm
Copy link
Contributor

@swiatekm swiatekm commented Sep 9, 2024

Description:

Add the controller for the TargetAllocator CRD. This is just the controller code with unit tests, it is not actually enabled and there's no user-facing impact.

Some associated changes include:

  • The Collector in TargetAllocator manifest generation parameters becomes optional. This is necessary because we need to be able to reconcile a TargetAllocator without a collector. This, in effect, starts a Target Allocator which doesn't allocate targets anywhere, but still computes them.
  • There's some associated changes to TA ConfigMap generation enabling the above.

Link to tracking Issue(s): #2422

Testing:

Documentation:

@swiatekm swiatekm added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 9, 2024
@swiatekm swiatekm force-pushed the feat/add-ta-reconciler branch 2 times, most recently from 80bf880 to 61ae85d Compare September 9, 2024 17:02
@swiatekm swiatekm marked this pull request as ready for review September 9, 2024 17:13
@swiatekm swiatekm requested a review from a team September 9, 2024 17:13
@swiatekm
Copy link
Contributor Author

swiatekm commented Sep 9, 2024

I'm planning to add more tests for this, but what's already here is reviewable as-is.

@swiatekm swiatekm requested a review from a team as a code owner September 22, 2024 18:35
@swiatekm swiatekm merged commit aa5a56f into open-telemetry:main Sep 22, 2024
33 checks passed
@swiatekm swiatekm deleted the feat/add-ta-reconciler branch September 22, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants