Create a must-gather for the operator #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
iblancasa
changed the title
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
…rator into feature/3149
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
…or into feature/3149
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
…or into feature/3149
…or into feature/3149
pavolloffay
reviewed
Aug 21, 2024
…rator into feature/3149
…or into feature/3149
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
…rator into feature/3149
…or into feature/3149
swiatekm
reviewed
Aug 27, 2024
…rator into feature/3149
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
…rator into feature/3149
…rator into feature/3149
Signed-off-by: Israel Blancas <iblancas@redhat.com>
swiatekm
reviewed
Sep 25, 2024
…rator into feature/3149
Signed-off-by: Israel Blancas <iblancas@redhat.com>
I added some unit tests and I think that should be enough. I'll ask for guidance from our QE expert to see if we can add some E2E tests but I think that can be done as part of a separate PR. |
pavolloffay
reviewed
Oct 2, 2024
| if err != nil { | ||
| log.Fatalln(err) | ||
| } | ||
| err = cluster.GetOpenTelemetryCollectors() |
There was a problem hiding this comment.
Just the collector. If you want, I can also add the collector logs but I would prefer to add it as part of a new PR. Otherwise, we will never merge this one.
…rator into feature/3149
Signed-off-by: Israel Blancas <iblancas@redhat.com>
|
@pavolloffay I addressed your comments. Is this ok to merge? |
pavolloffay
reviewed
Oct 7, 2024
.chloggen/3149-add-must-gather.yaml
Outdated
| change_type: enhancement | ||
|
|
||
| # The name of the component, or a single word describing the area of concern, (e.g. collector, target allocator, auto-instrumentation, opamp, github action) | ||
| component: instrumentation, collector |
| if err != nil { | ||
| log.Fatalln(err) | ||
| } | ||
| err = cluster.GetOpenTelemetryCollectors() |
…rator into feature/3149
pavolloffay
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: adds
must-gathertool for troubleshooting.I created it using Golang so we can add it directly to the operator container image.