Define components more clearly in v1beta1 #2915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2024
…or into cleanup-part-2
pavolloffay
reviewed
May 2, 2024
apis/v1beta1/config.go
Outdated
| @@ -121,16 +136,16 @@ func (c *Config) GetEnabledComponents() map[ComponentType]map[string]interface{} | |||
| // Config encapsulates collector config. | |||
| type Config struct { | |||
| // +kubebuilder:pruning:PreserveUnknownFields | |||
| Receivers AnyConfig `json:"receivers" yaml:"receivers"` | |||
| Receivers map[string]*AnyConfig `json:"receivers" yaml:"receivers"` | |||
There was a problem hiding this comment.
Could you explain why this change is needed? AnyConfig is already a map
type AnyConfig struct {
Object map[string]interface{} `json:"-" yaml:",inline"`
}There was a problem hiding this comment.
this is because we know that any component definition is also an AnyConfig, therefore receivers is really a map from component name to an AnyConfig.
After trying to futz with the types, though, I don't i'm able to make this serialization work.
|
I cannot make this work for the life of me. Closing and will try a different approach 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Defines components as a map from component name to an AnyConfig
Link to tracking Issue(s):
Part of #2603
Testing: unit tests
Documentation: n/a