Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RBAC creation resources for k8sattributes #2789

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

iblancasa
Copy link
Contributor

Closes #2788.

Also, fixes some errors in the log output.

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa iblancasa requested a review from a team March 25, 2024 16:48
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test for this?

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@jaronoff97 jaronoff97 merged commit d1f89a2 into open-telemetry:main Mar 29, 2024
31 checks passed
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RBAC resources for k8sattributes processor are not being created
4 participants