Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HPA] Properly update HPA behavior field #1553

Conversation

moh-osman3
Copy link
Contributor

Resolves #1516

@moh-osman3 moh-osman3 marked this pull request as ready for review March 3, 2023 08:43
@moh-osman3 moh-osman3 requested a review from a team March 3, 2023 08:43
Copy link
Contributor

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @moh-osman3! One nit.

tests/e2e/autoscale/02-install.yaml Outdated Show resolved Hide resolved
@pavolloffay pavolloffay merged commit 5abbc81 into open-telemetry:main Mar 6, 2023
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* update behavior

* chloggen and add to validation script

* validate scaleUp

* dereference pointer

* change e2e test comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HPA] .spec.Autoscaler.behavior is not updated properly
4 participants