-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Fix Target Allocator tests #1403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
added
Skip Changelog
PRs that do not require a CHANGELOG.md entry
area:target-allocator
Issues for target-allocator
labels
Jan 26, 2023
Aneurysm9
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the import ordering, otherwise LGTM.
kristinapathak
approved these changes
Jan 26, 2023
iblancasa
approved these changes
Jan 26, 2023
matej-g
approved these changes
Jan 27, 2023
pavolloffay
approved these changes
Jan 27, 2023
iblancasa
pushed a commit
to iblancasa/opentelemetry-operator
that referenced
this pull request
Jan 31, 2023
* Change the github action to match the operator * Add chloggen * Fix tests * imports
iblancasa
pushed a commit
to iblancasa/opentelemetry-operator
that referenced
this pull request
Feb 1, 2023
* Change the github action to match the operator * Add chloggen * Fix tests * imports
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Change the github action to match the operator * Add chloggen * Fix tests * imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:target-allocator
Issues for target-allocator
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1352 introduced a bug for the server tests from the new signature. This fixes that by wrapping it in a gin context