Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix Target Allocator tests #1403

Merged
merged 7 commits into from
Jan 27, 2023

Conversation

jaronoff97
Copy link
Contributor

#1352 introduced a bug for the server tests from the new signature. This fixes that by wrapping it in a gin context

@jaronoff97 jaronoff97 requested a review from a team January 26, 2023 16:54
@jaronoff97 jaronoff97 added Skip Changelog PRs that do not require a CHANGELOG.md entry area:target-allocator Issues for target-allocator labels Jan 26, 2023
Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the import ordering, otherwise LGTM.

@pavolloffay pavolloffay merged commit 6814271 into open-telemetry:main Jan 27, 2023
@jaronoff97 jaronoff97 deleted the 1383-fix-tests branch January 27, 2023 15:35
iblancasa pushed a commit to iblancasa/opentelemetry-operator that referenced this pull request Jan 31, 2023
* Change the github action to match the operator

* Add chloggen

* Fix tests

* imports
iblancasa pushed a commit to iblancasa/opentelemetry-operator that referenced this pull request Feb 1, 2023
* Change the github action to match the operator

* Add chloggen

* Fix tests

* imports
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* Change the github action to match the operator

* Add chloggen

* Fix tests

* imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:target-allocator Issues for target-allocator Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants