Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Kubernetes 1.26 #1386

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Jan 20, 2023

Signed-off-by: Pavol Loffay p.loffay@gmail.com

Resolves #1385

@pavolloffay pavolloffay requested a review from a team January 20, 2023 09:49
@pavolloffay pavolloffay added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 20, 2023
Copy link
Contributor

@iblancasa iblancasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure in teh autoscale E2E test, is fixed as part of #1365

Copy link
Contributor

@iblancasa iblancasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit tests depends on the KUBE_VERSION too

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay
Copy link
Member Author

The unit tests depends on the KUBE_VERSION too

reverting back the default to 1.24 for the unit tests.

@iblancasa
Copy link
Contributor

@pavolloffay could you re-run the E2E tests? It seems something didn´t work properly with GitHub Actions Workflows.

@pavolloffay
Copy link
Member Author

pavolloffay commented Mar 9, 2023

@pavolloffay could you re-run the E2E tests? It seems something didn´t work properly with GitHub Actions Workflows.

All tests passed but the e2e 1.25 job needs to be removed from the required actions.

@pavolloffay
Copy link
Member Author

Asked for maintenance permissions open-telemetry/community#1381

@arminru
Copy link
Member

arminru commented Mar 14, 2023

@pavolloffay I removed the 1.25 check and re-ran your tests so I can add 1.26 as required instead. You should already be able to merge the PR, however.

@pavolloffay pavolloffay merged commit b2227b0 into open-telemetry:main Mar 14, 2023
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* Test on Kubernetes 1.26

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Keep using 1.24 in unit tests

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

---------

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test on Kuberentes 1.26.0
4 participants