Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the target allocator build to not run it as root #1345

Merged
merged 7 commits into from
Jan 9, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .chloggen/1346-run-ta-nonroot.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. operator, target allocator, github action)
component: target allocator

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: "Run the target allocator as non root user"

# One or more tracking issues related to the change
issues: [1346]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
38 changes: 23 additions & 15 deletions cmd/otel-allocator/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,26 +1,34 @@
# Build the target allocator binary
FROM golang:1.19 as builder

WORKDIR /app

# Copy go mod and sum files
COPY go.mod go.sum ./

WORKDIR /workspace
# Copy the Go Modules manifests
COPY go.mod go.mod
COPY go.sum go.sum
# cache deps before building and copying source so that we don't need to re-download as much
# and so that source changes don't invalidate our downloaded layer
RUN go mod download

COPY . .
# Copy the go source
iblancasa marked this conversation as resolved.
Show resolved Hide resolved
COPY main.go main.go
COPY allocation/ allocation/
COPY collector/ collector/
COPY config/ config/
COPY diff/ diff/
COPY prehook/ prehook/
COPY server/ server/
COPY target/ target/
COPY watcher/ watcher/

# Build the Go app
RUN CGO_ENABLED=0 GOOS=linux go build -a -installsuffix cgo -o main .

######## Start a new stage from scratch #######
FROM alpine:latest

RUN apk --no-cache add ca-certificates

WORKDIR /root/

# Use distroless as minimal base image to package the manager binary
# Refer to https://github.com/GoogleContainerTools/distroless for more details
FROM gcr.io/distroless/static:nonroot
iblancasa marked this conversation as resolved.
Show resolved Hide resolved
WORKDIR /
# Copy the pre-built binary file from the previous stage
COPY --from=builder /app/main .
COPY --from=builder /workspace/main .
USER 65532:65532

ENTRYPOINT ["./main"]
ENTRYPOINT ["/main"]