[chore] Change the E2E automation to run the tests in OpenShift #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinearls
approved these changes
Nov 16, 2022
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
iblancasa
force-pushed
the
run-tests-openshift
branch
from
eda82ed
to
72af183
Compare
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
…or into run-tests-openshift
…or into run-tests-openshift
|
I'm not able to reproduce the error in the |
|
@iblancasa as part of this PR #1233 I just added a change 1213f7b to skip that test as it was failing frequently for me |
pavolloffay
reviewed
Dec 1, 2022
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
…try-operator into run-tests-openshift
pavolloffay
reviewed
Dec 1, 2022
…or into run-tests-openshift
…try-operator into run-tests-openshift
…or into run-tests-openshift
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
…or into run-tests-openshift
iblancasa
changed the title
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
iblancasa
requested review from
pavolloffay and
jkandasa
and removed request for
frzifus and
pavolloffay
pavolloffay
reviewed
Dec 19, 2022
hack/ensure-collector-deployment.go
Outdated
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package main |
There was a problem hiding this comment.
I am not a big fan to see this written in golang.
Did you use golang because of te poll?
There was a problem hiding this comment.
I had two options: Golang or shell. Shell will be more difficult to understand/maintain. Also, stuff like the poll mechanism is implemented in the libraries we use: with bash I would have to implement it.
hack/ensure-collector-deployment.go
Outdated
| fmt.Println("Wait until the creation of OTEL Collectors is available") | ||
| pollInterval := 3 * time.Second | ||
| timeoutPoll := time.Duration(timeout) * time.Second | ||
| err = wait.Poll(pollInterval, timeoutPoll, func() (done bool, err error) { |
There was a problem hiding this comment.
why the poll is used to apply the install manifest? Why does the installation fail? Is it because the webhook or the CRD is not recognized in the cluster?
There was a problem hiding this comment.
Because the error I pointed in #1254 (comment). As I pointed in previous comments: I don't know how to solve it without adding sleep statements or trying to create a resource until the creation doesn't fail. If you know a better way to do it, please, give me a hint.
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
iblancasa
requested review from
pavolloffay and
frzifus
and removed request for
jkandasa,
pavolloffay and
frzifus
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
…or into run-tests-openshift
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
pavolloffay
approved these changes
Dec 20, 2022
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
This was referenced Feb 2, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…-telemetry#1254) * Run the E2E tests in OpenShift Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Set version for GitHub Actions workflow Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Fix CI Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Apply some changes to simplify the upgrade E2E test Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Fix CI Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Fix CI Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Install OpenShift routes only if needed Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Trigger Build Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Remove cert-manager installation from deployment step Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Trigger Build Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Ensure the webhook don't fail when kubectl apply Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Fix coding standard issues Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Fix coding standard issues Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Increase timeout for golangci Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Apply changes requested in CR Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Change timeout to 500ms Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Change program file name Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Do the check without depending on a manifest file Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Change program file name Signed-off-by: Israel Blancas <iblancasa@gmail.com> Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs adds some changes to the E2E automation in order to allow the usage of Kubernetes clusters not created with
kind. It also allows the usage of OpenShift.