.NET - enable bytecode instrumentation #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@open-telemetry/dotnet-instrumentation-approvers FYI |
|
@avadhut123pisal, FYI |
lachmatt
approved these changes
Sep 13, 2022
pellared
approved these changes
Sep 13, 2022
nrcventura
approved these changes
Sep 13, 2022
rajkumar-rangaraj
approved these changes
Sep 13, 2022
pavolloffay
approved these changes
Sep 15, 2022
|
@Kielek I think it MAY be good to offer an easy way to disable byte-code instrumentation (disable attaching the .NET Profiler) as this can have negative consequences on the instrumented application's performance (maybe it was not enabled by default on purpose?) |
My perspective is to offer as broad auto-instrumentation as possible. |
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* .NET Auto Instrumentation - support for byte code instrumentation * extract method to set env variable * code review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables bytecode instrumentations. All of them are enabled by default.
For v.0.3.1-beta.1 it extends set of supported libraries: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/v0.3.1-beta.1/docs/config.md#instrumented-traces-libraries-and-frameworks