Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix]- adds dotnet-auto-instrumentation image version env variable to the operator publish workflow #1060

Merged
merged 2 commits into from
Aug 30, 2022
Merged

[fix]- adds dotnet-auto-instrumentation image version env variable to the operator publish workflow #1060

merged 2 commits into from
Aug 30, 2022

Conversation

avadhut123pisal
Copy link
Contributor

  1. AUTO_INSTRUMENTATION_DOTNET_VERSION environment variable was not getting passed as a build arguments to the Operator image through the Operator image publish workflow.
  2. The Operator images released for version 0.57.2 and 0.58.0 are not having this variable value set, because of which it has defaulted to 0.0.0, which is causing an error while pulling the docker image for the .Net auto-instrumentation.

Fixes #1059

@avadhut123pisal avadhut123pisal requested a review from a team August 25, 2022 16:33
@avadhut123pisal avadhut123pisal mentioned this pull request Aug 25, 2022
Closed
@TylerHelmuth
Copy link
Member

Will a new operator release need to happen after this PR is merged in order to update the tags?

@avadhut123pisal
Copy link
Contributor Author

Will a new operator release need to happen after this PR is merged in order to update the tags?

Yes.

@VineethReddy02 VineethReddy02 merged commit c900d0e into open-telemetry:main Aug 30, 2022
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@avadhut123pisal
adds dotnet-autoinstrumentation image version env var to the operator…
4a6625d 
… image publish workflow (open-telemetry#1060)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VineethReddy02 VineethReddy02 VineethReddy02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] - Image of .Net auto-instrumentation can't be pulled
3 participants
@avadhut123pisal @TylerHelmuth @VineethReddy02