Update the target allocator on any manifest change #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
changed the title
secustor
reviewed
Aug 10, 2022
secustor
approved these changes
Aug 10, 2022
Aneurysm9
approved these changes
Aug 10, 2022
jpkrohling
approved these changes
Aug 10, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Update the target allocator on any manifest change * Change test to check for prometheusCR change validation * Fix test * Updated test to be more flexible for the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1008 by removing the special target allocator behavior for not updating the container's spec. The desired behavior is to update the TA on a spec change. This also fixes a superfluous print from the operator that clogs operator logs due to the fact that the prometheus receiver has no endpoint to expose as it is a scrape based receiver.
Evidence of testing:
There was no prometheusCR flag initially
