Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collectors with same name create ClusterRoleBinding with same name #2862

Closed
iblancasa opened this issue Apr 16, 2024 · 1 comment · Fixed by #2787
Closed

Collectors with same name create ClusterRoleBinding with same name #2862

iblancasa opened this issue Apr 16, 2024 · 1 comment · Fixed by #2787
Labels
area:collector Issues for deploying collector bug Something isn't working needs triage

Comments

@iblancasa
Copy link
Contributor

Component(s)

No response

What happened?

Description

When two OTEL Collectors are created with the same name and the operator can create ClusterRoleBindings, the first one will be overridden by the second one. The permissions will mismatch and the namespace.

Steps to Reproduce

Create two Collectors with the same name in different namespaces with the ability to create RBAC resources. The second one will override the first one.

Kubernetes Version

.

Operator version

.

Collector version

.

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

Log output

No response

Additional context

No response

@iblancasa iblancasa added bug Something isn't working needs triage labels Apr 16, 2024
@iblancasa
Copy link
Contributor Author

Added the fix as part of #2787.

@iblancasa iblancasa changed the title Collectors with same name can create ClusterRoleBinding with same name Collectors with same name create ClusterRoleBinding with same name Apr 16, 2024
iblancasa added a commit to iblancasa/opentelemetry-operator that referenced this issue Apr 16, 2024
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@pavolloffay pavolloffay added the area:collector Issues for deploying collector label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:collector Issues for deploying collector bug Something isn't working needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants