Skip to content

Fix telemetry API receiver: creating empty log record(s) by platform events #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jerrytfleung
Copy link
Contributor

Problem

Empty log records are created when subscribing platform type in telemetry API receiver and has telemetry API receiver in logs pipeline

Investigation

  1. From here, log record(s) are created before checking the type of the event. Causing telemetry API receiver creates empty log record for platform.* events

Solution

  • Making sure the type is either function or extension before creating an log record.
  • Added related unit test cases to verify the function.

This PR is to fix this problem.

@jerrytfleung jerrytfleung requested a review from a team September 13, 2024 03:10
@tylerbenson tylerbenson merged commit c9e67c4 into open-telemetry:main Sep 24, 2024
12 checks passed
@tylerbenson tylerbenson added the go Pull requests that update Go code label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants