feat(http-plugin): add options to disable new spans if no parent #931

[vmarchaud]

No description provided.

[vmarchaud]

As #930, lint is failing because of GTS versions

[codecov-io]

Codecov Report

Merging #948 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #948      +/-   ##
==========================================
+ Coverage   95.01%   95.06%   +0.05%     
==========================================
  Files         212      212              
  Lines        8827     8898      +71     
  Branches      797      801       +4     
==========================================
+ Hits         8387     8459      +72     
+ Misses        440      439       -1     

Impacted Files	Coverage Δ
packages/opentelemetry-plugin-http/src/http.ts	97.70% <100.00%> (+0.12%)	⬆️
...y-plugin-http/test/functionals/http-enable.test.ts	96.88% <100.00%> (+0.59%)	⬆️
...lemetry-plugin-http/test/utils/DummyPropagation.ts	100.00% <0.00%> (+6.66%)	⬆️

[OlivierAlbertini]

look good

[dyladan]

@open-telemetry/javascript-approvers we need more reviews on this

[dyladan]

LGTM thanks

[obecny]

lgtm, one comment

[dyladan]

@vmarchaud can you help me understand why you decided to create a non recording span rather than just returning the NOOP span provided by the API?

You've introduced a hard dependency on our core/sdk, which means a third party implementation of an SDK will not be able to work with this plugin.

[vmarchaud]

@dyladan Well if i remember correctly using a NoopSpan wasn't propagating the context, but if i'm mistaken i see no reason to not use a NoopSpan instead

[dyladan]

I would like to remove the dependency on core for all plugins if possible. In the current state, plugins are only compatible with the default sdk, but won't be interoperable with third party sdks. The http plugin is one of the only ones that depends on something other than BasePlugin in core.