-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add express to default list of instrumented plugins #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
dyladan,
markwolff,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
March 30, 2020 21:18
Codecov Report
@@ Coverage Diff @@
## master #914 +/- ##
==========================================
- Coverage 94.32% 92.90% -1.43%
==========================================
Files 245 244 -1
Lines 10970 10959 -11
Branches 1061 1064 +3
==========================================
- Hits 10348 10181 -167
- Misses 622 778 +156
|
vmarchaud
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with that if we release #910 with it :)
dyladan
approved these changes
Mar 31, 2020
obecny
approved these changes
Mar 31, 2020
Merged
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
express
to default list of instrumented plugins/cc @vmarchaud