-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix build errors #747
chore: fix build errors #747
Conversation
I'm reviewing this and on my branch I did exactly the same thing (without changing tdd script) and I get the same issue... |
looking into it |
ccfa941
to
7760b3a
Compare
Codecov Report
@@ Coverage Diff @@
## master #747 +/- ##
=========================================
+ Coverage 96.22% 96.5% +0.27%
=========================================
Files 208 67 -141
Lines 9488 1603 -7885
Branches 809 131 -678
=========================================
- Hits 9130 1547 -7583
+ Misses 358 56 -302
|
@open-telemetry/javascript-approvers I know this has had a lot of updates but I just squashed it all down into two commits. Please take a look and review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks for fixing the build.
* chore: switch from yarn to npm * chore: ignore unpublished package
* chore: switch from yarn to npm * chore: ignore unpublished package
Fixes an issue that prevented lerna from being used on node 8.todo: create a follow up PR that removes the skip of the broken link after it is published to npm #751