-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: create a getting started guide #566
Merged
danielkhan
merged 5 commits into
open-telemetry:master
from
dynatrace-oss-contrib:getting-started
Nov 25, 2019
Merged
docs: create a getting started guide #566
danielkhan
merged 5 commits into
open-telemetry:master
from
dynatrace-oss-contrib:getting-started
Nov 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
bg451,
danielkhan,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
November 23, 2019 18:59
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
==========================================
- Coverage 90.12% 90.12% -0.01%
==========================================
Files 150 149 -1
Lines 7381 7400 +19
Branches 667 669 +2
==========================================
+ Hits 6652 6669 +17
- Misses 729 731 +2
|
dyladan
force-pushed
the
getting-started
branch
from
November 23, 2019 19:31
a5ffac2
to
e61d852
Compare
mayurkale22
reviewed
Nov 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm
dyladan
force-pushed
the
getting-started
branch
from
November 25, 2019 17:34
568c21e
to
3d74cea
Compare
mayurkale22
approved these changes
Nov 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added 2 minor comments
danielkhan
approved these changes
Nov 25, 2019
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
What have you done
Tracing
Metrics
See the guide in its current form here https://github.com/dynatrace-oss-contrib/opentelemetry-js/blob/getting-started/getting-started/Getting-Started.md