Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web-common): add incubating semconv to package #5446

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Makes the package follow the rules as defined in the guidelines. Since @opentelemetry/semantic-conventions is now unpinned, we should not use the /incubating entry point.

Follows up on #5439

@pichlermarc pichlermarc requested a review from a team as a code owner February 11, 2025 13:31
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.77%. Comparing base (4f91c1d) to head (fe6128a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5446   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files         308      309    +1     
  Lines        7966     7967    +1     
  Branches     1678     1678           
=======================================
+ Hits         7550     7551    +1     
  Misses        416      416           
Files with missing lines Coverage Δ
...ckages/web-common/src/SessionLogRecordProcessor.ts 100.00% <100.00%> (ø)
...al/packages/web-common/src/SessionSpanProcessor.ts 100.00% <100.00%> (ø)
experimental/packages/web-common/src/semconv.ts 100.00% <100.00%> (ø)

@pichlermarc pichlermarc added this pull request to the merge queue Feb 11, 2025
Merged via the queue into open-telemetry:main with commit 4fb9c5a Feb 11, 2025
18 checks passed
@pichlermarc pichlermarc deleted the chore/web-common-vendor-semconv branch February 11, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants