chore(semantic-conventions): restore min-supported node to >=14 #5407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It had been bumped to >=18 along with most other packages in the 'next' branch. However, the semconv package (similar to the 'api' package) is staying on 1.x, so we don't want to drop support for older Node.js versions in a minor.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5407 +/- ##
==========================================
+ Coverage 94.54% 94.64% +0.09%
==========================================
Files 318 318
Lines 8051 8033 -18
Branches 1694 1688 -6
==========================================
- Hits 7612 7603 -9
+ Misses 439 430 -9 |
maryliag
approved these changes
Jan 30, 2025
pichlermarc
approved these changes
Jan 31, 2025
Merged
via the queue into
open-telemetry:main
with commit Jan 31, 2025
05c2869
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It had been bumped to >=18 along with most other packages in the 'next' branch. However, the semconv package (similar to the 'api' package) is staying on 1.x, so we don't want to drop support for older Node.js versions in a minor.
This should get merged before a next verison of the semconv package is released. The latest release (1.28.0) has
>=14.