-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instrumentation-http)!: reduce public API surface by removing exports and making protected methods private #5124
Merged
pichlermarc
merged 6 commits into
open-telemetry:main
from
dynatrace-oss-contrib:feat/cleanup-instr-http
Nov 8, 2024
Merged
feat(instrumentation-http)!: reduce public API surface by removing exports and making protected methods private #5124
pichlermarc
merged 6 commits into
open-telemetry:main
from
dynatrace-oss-contrib:feat/cleanup-instr-http
Nov 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ports and making protrected methods private
pichlermarc
changed the title
feat(instrumentation-http):! reduce public API surface by removing exports and making protected methods private
feat(instrumentation-http)!: reduce public API surface by removing exports and making protected methods private
Nov 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5124 +/- ##
=======================================
Coverage 93.18% 93.18%
=======================================
Files 315 315
Lines 8086 8086
Branches 1617 1617
=======================================
Hits 7535 7535
Misses 551 551 |
hectorhdzg
reviewed
Nov 7, 2024
experimental/packages/opentelemetry-instrumentation-http/src/internal-types.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Nov 7, 2024
experimental/packages/opentelemetry-instrumentation-http/src/internal-types.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
trentm
approved these changes
Nov 7, 2024
…nternal-types.ts Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>
…nternal-types.ts Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>
povilasv
pushed a commit
to povilasv/opentelemetry-js
that referenced
this pull request
Nov 11, 2024
…ports and making protected methods private (open-telemetry#5124) Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
While working on #5091, I noticed that we can't really change the
utils
function signatures without introducing a breaking change, they are actually all exported. There's also some protected methods that are part of the public API which we may not want to be there.This PR introduces the following breaking changes:
utils
exports (these were, from what I can tell, all intended for internal consumption, not for the user)types
that are not used in the options or public/protected methods, and moves them tointernal-types
instead_getPatch*
methods private (they were previously protected)Type of change
How Has This Been Tested?