Resource: remove unnecessary diagnostic when accessing attributes #5119
+1
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le async attributes are resolving
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5119 +/- ##
==========================================
- Coverage 93.21% 93.21% -0.01%
==========================================
Files 315 315
Lines 8096 8094 -2
Branches 1622 1621 -1
==========================================
- Hits 7547 7545 -2
Misses 549 549
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion issue: #5114
Since
Resourcealready has 2 methods to deal with yet to be resolved attributes (asyncAttributesPendingandwaitForAsyncAttributes), the diagnostic seems redundant and perhaps misleading (since it's more of a debug message than an actual error).