Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events,logs): drop outdated API from devDependencies and align types #5013

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Sep 24, 2024

Which problem is this PR solving?

I saw that there's two devDependency entries old @opentelemetry/api-events and @opentelemetry/api-logs packages, which cause an old package to be present for these two packages.

The current version is actually specified as a dependency so removing the devDependency is safe.

Since the devDependency pulled in the local types, we had some type-mismatch with in @opentelemetry/sdk-logs where null was not an allowed input with the changed type.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Existing tests

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.94%. Comparing base (f8ab559) to head (9a7bc19).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5013      +/-   ##
==========================================
+ Coverage   93.39%   93.94%   +0.54%     
==========================================
  Files          46      310     +264     
  Lines         712     8138    +7426     
  Branches      120     1633    +1513     
==========================================
+ Hits          665     7645    +6980     
- Misses         47      493     +446     
Files with missing lines Coverage Δ
experimental/packages/sdk-logs/src/LogRecord.ts 98.09% <100.00%> (ø)

... and 265 files with indirect coverage changes

@pichlermarc pichlermarc changed the title fix(events,logs): drop old experimental packages from dependencies fix(events,logs): drop old experimental packages from dependencies and align types Sep 24, 2024
@pichlermarc pichlermarc changed the title fix(events,logs): drop old experimental packages from dependencies and align types fix(events,logs): drop outdated API from devDependencies and align types Sep 24, 2024
@pichlermarc pichlermarc marked this pull request as ready for review September 24, 2024 13:24
@pichlermarc pichlermarc requested a review from a team as a code owner September 24, 2024 13:24
@pichlermarc pichlermarc added this pull request to the merge queue Sep 25, 2024
Merged via the queue into open-telemetry:main with commit 9de3151 Sep 25, 2024
21 checks passed
@pichlermarc pichlermarc deleted the fix/old-events-logs-deps branch September 25, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants