Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove --openssl-legacy-provider option #5012

Conversation

pichlermarc
Copy link
Member

Saw this earlier when working on #5010.
We needed this when we were still using webpack 4, but we've fully migrated to webpack 5, so we can drop it 🙂

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.92%. Comparing base (f8ab559) to head (081e9e1).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5012      +/-   ##
==========================================
+ Coverage   93.39%   93.92%   +0.52%     
==========================================
  Files          46      310     +264     
  Lines         712     8135    +7423     
  Branches      120     1632    +1512     
==========================================
+ Hits          665     7641    +6976     
- Misses         47      494     +447     

see 266 files with indirect coverage changes

@pichlermarc pichlermarc marked this pull request as ready for review September 23, 2024 14:46
@pichlermarc pichlermarc requested a review from a team as a code owner September 23, 2024 14:46
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning this up!

@pichlermarc pichlermarc added this pull request to the merge queue Sep 23, 2024
Merged via the queue into open-telemetry:main with commit 42be951 Sep 23, 2024
21 of 22 checks passed
@pichlermarc pichlermarc deleted the chore/remove-openssl-legacy-provider-option branch September 23, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants