ci: switch to codecov action #5011
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5011 +/- ##
==========================================
+ Coverage 93.39% 93.93% +0.54%
==========================================
Files 46 310 +264
Lines 712 8135 +7423
Branches 120 1632 +1512
==========================================
+ Hits 665 7642 +6977
- Misses 47 493 +446 |
| @@ -29,9 +29,6 @@ | |||
| "repository": "open-telemetry/opentelemetry-js", | |||
| "scripts": { | |||
| "clean": "tsc --build --clean tsconfig.json tsconfig.esm.json tsconfig.esnext.json", | |||
| "codecov:browser": "nyc report --reporter=json && codecov -f coverage/*.json -p ../", | |||
| "codecov:webworker": "nyc report --reporter=json && codecov -f coverage/*.json -p ../", | |||
| "codecov": "nyc report --reporter=json && codecov -f coverage/*.json -p ../", | |||
There was a problem hiding this comment.
Looks like the new codecov is able to search coverage files automatically (logs)
| @@ -52,8 +52,9 @@ jobs: | |||
| fi | |||
| npm run test | |||
| - name: Report Coverage | |||
| run: npm run codecov | |||
| if: ${{ matrix.node_version == '14' }} | |||
There was a problem hiding this comment.
so now we're collecting coverage for all node versions?
There was a problem hiding this comment.
yep 🙂
I figured that's better anyway as there we actually won't end up with supposedly-missing where we do different things for different Node.js versions.
There was a problem hiding this comment.
Works better here than in contrib, where we sometimes don't run all the tests to save time.
Here we always run the full suite of tests on both PRs and main, so we won't have any inconsistencies by doing this 🙂
Which problem is this PR solving?
The
codecovpackage is deprecated and has been intermittently (see here, and here) failing workflows. This PR switches to the action which is the supported way of doing things.This also aligns the tooling more with the contrib repo, where we've been successfully using this action for quite a while now.