Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-trace-base): replace SpanAttributes with Attributes #5009

Conversation

david-luna
Copy link
Contributor

Which problem is this PR solving?

Replaces SpanAttributes with Attributes

Refs #4175

Short description of the changes

Replace the interfaces in sources & tests. This PR targeting next since the version bump of @opentelemetry/api package makes it a breaking change.

How Has This Been Tested?

Ran the test suite for the SDK trace base.

@david-luna david-luna requested a review from a team as a code owner September 23, 2024 10:59
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.94%. Comparing base (32564ad) to head (c649c4b).
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #5009      +/-   ##
==========================================
- Coverage   93.96%   93.94%   -0.02%     
==========================================
  Files         310      310              
  Lines        8147     8147              
  Branches     1630     1630              
==========================================
- Hits         7655     7654       -1     
- Misses        492      493       +1     
Files with missing lines Coverage Δ
...ckages/opentelemetry-sdk-trace-base/src/Sampler.ts 100.00% <ø> (ø)
packages/opentelemetry-sdk-trace-base/src/Span.ts 97.57% <100.00%> (ø)
...y-sdk-trace-base/src/sampler/ParentBasedSampler.ts 83.87% <ø> (ø)

... and 1 file with indirect coverage changes

CHANGELOG.md Outdated Show resolved Hide resolved
@pichlermarc pichlermarc merged commit e15d5b3 into open-telemetry:next Sep 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants