fix(otlp-exporter-base)!: ensure we do not retry after the timeout has elapsed #4889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This is a fix for an unreleased bug (therefore skipping changelog). While working on a follow up for the web exporters, I realized that the
RetryingTransport
I introduced in #4743 it does not correctly handle timeouts. Instead of computing remaining time it does not take care of timeouts at all, meaning that consecutivesend
calls can actually take too long when retrying. This changes the transport interface so that we can set a timeout for eachsend
call, and computes the remaining time to pass to the underlyingsend
call.Example (correct behavior):
503
, in 10ms, says to retry-after 500ms503
, in 10ms, says to retry-after 500msExample (current behavior):
503
, in 10ms, says to retry-after 500ms503
, in 10ms, says to retry-after 500msEnables #4895
Type of change
Please delete options that are not relevant.
How Has This Been Tested?