Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing problem with load event and performance for loadend #469

Merged
merged 6 commits into from
Nov 2, 2019
Merged

chore: fixing problem with load event and performance for loadend #469

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd28684
chore: fixing problem with load event and performance for loadend
obecny Oct 30, 2019
a1a026b
chore: clean up in unit tests
obecny Oct 30, 2019
e7bb2d2
Merge branch 'master' into document-load-fix
obecny Oct 30, 2019
5ceb9ce
chore: removing delay from timeouts
obecny Nov 1, 2019
60b2f5b
chore: removing delay from timeout
obecny Nov 1, 2019
502f0d0
Merge branch 'master' into document-load-fix
obecny Nov 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: clean up in unit tests
  • Loading branch information
@obecny
obecny committed Oct 30, 2019
commit a1a026bd94ed9441b08c2dc98907235b6c5cba88
24 changes: 0 additions & 24 deletions packages/opentelemetry-plugin-document-load/test/documentLoad.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,14 +193,6 @@ describe('DocumentLoad Plugin', () => {
spyExport = sinon
.stub(window.performance, 'getEntriesByType')
.returns([entries]);

tracer = new BasicTracer();
logger = new ConsoleLogger();
config = {};
plugin = new DocumentLoad();
dummyExporter = new DummyExporter();
spanProcessor = new SimpleSpanProcessor(dummyExporter);
tracer.addSpanProcessor(spanProcessor);
});

it('should export correct span with events', done => {
Expand Down Expand Up @@ -260,14 +252,6 @@ describe('DocumentLoad Plugin', () => {
spyExport = sinon
.stub(window.performance, 'getEntriesByType')
.returns([entriesWithoutLoadEventEnd]);

tracer = new BasicTracer();
logger = new ConsoleLogger();
config = {};
plugin = new DocumentLoad();
dummyExporter = new DummyExporter();
spanProcessor = new SimpleSpanProcessor(dummyExporter);
tracer.addSpanProcessor(spanProcessor);
});

it('should still export rootSpan and fetchSpan', done => {
Expand Down Expand Up @@ -302,14 +286,6 @@ describe('DocumentLoad Plugin', () => {
writable: true,
value: entriesFallback,
});

tracer = new BasicTracer();
logger = new ConsoleLogger();
config = {};
plugin = new DocumentLoad();
dummyExporter = new DummyExporter();
spanProcessor = new SimpleSpanProcessor(dummyExporter);
tracer.addSpanProcessor(spanProcessor);
});

it('should export correct span with events', done => {
Expand Down