-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jaeger-remote-sampler): Implement jaeger remote sampler #4589
Merged
pichlermarc
merged 64 commits into
open-telemetry:main
from
legalimpurity:feature/implement_jaeger_remote_sampler
Aug 23, 2024
Merged
feat(jaeger-remote-sampler): Implement jaeger remote sampler #4589
pichlermarc
merged 64 commits into
open-telemetry:main
from
legalimpurity:feature/implement_jaeger_remote_sampler
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…legalimpurity/opentelemetry-js into feature/implement_jaeger_remote_sampler
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4589 +/- ##
==========================================
+ Coverage 90.77% 92.86% +2.08%
==========================================
Files 90 331 +241
Lines 1930 9571 +7641
Branches 417 2054 +1637
==========================================
+ Hits 1752 8888 +7136
- Misses 178 683 +505
|
…ger_remote_sampler
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…lemetry#4589) Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com> Co-authored-by: Trent Mick <trentm@gmail.com>
This was referenced Sep 19, 2024
This was referenced Sep 20, 2024
This was referenced Sep 24, 2024
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This is an implementation of JaegerRemoteSampler. This follows the specification mentioned here.
Fixes #4534
Short description of the changes
Add a new samper implementation in experimental packages.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Have added full coverage for entire code.
Checklist: