-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ConsoleMetricExporter Should Not Export Shallowly #4522
Merged
pichlermarc
merged 3 commits into
open-telemetry:main
from
JacksonWeber:jacksonweber/increase-console-depth
Mar 6, 2024
Merged
fix: ConsoleMetricExporter Should Not Export Shallowly #4522
pichlermarc
merged 3 commits into
open-telemetry:main
from
JacksonWeber:jacksonweber/increase-console-depth
Mar 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l information from metrics.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4522 +/- ##
=======================================
Coverage 92.40% 92.40%
=======================================
Files 330 330
Lines 9531 9531
Branches 2036 2036
=======================================
Hits 8807 8807
Misses 724 724
|
pichlermarc
added
bug
Something isn't working
priority:p4
Bugs and spec inconsistencies which do not fall into a higher prioritization
labels
Mar 4, 2024
pichlermarc
reviewed
Mar 4, 2024
pichlermarc
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this 👍
This was referenced Jun 15, 2024
This was referenced Jun 21, 2024
This was referenced Jun 22, 2024
This was referenced Jul 3, 2024
This was referenced Jul 4, 2024
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…y#4522) * fix: (ConsoleMetricExporter): Increase console log depth to get useful information from metrics. * update: add contribution to changelog. * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
priority:p4
Bugs and spec inconsistencies which do not fall into a higher prioritization
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Changed the depth of which the ConsoleMetricExporter will log such that values on metrics like attributes, startTime, endTime, and value will be logged entirely.
Example:
Fixes #4061
Short description of the changes
Change the console.dir depth to
null
to ensure objects part of the output metrics are fully serialized in the console.Type of change
How Has This Been Tested?
Create a sample application that logs metrics to the console using the
ConsoleMetricExporter
. Observe the output metrics for correctness.Checklist: