fix(exporter-logs-otlp-*): set User-Agent header #4398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4398 +/- ##
==========================================
+ Coverage 92.21% 92.22% +0.01%
==========================================
Files 336 336
Lines 9515 9521 +6
Branches 2017 2017
==========================================
+ Hits 8774 8781 +7
+ Misses 741 740 -1
|
pichlermarc
approved these changes
Jan 18, 2024
JamieDanielson
approved these changes
Jan 18, 2024
trentm
approved these changes
Jan 22, 2024
pichlermarc
changed the title
pichlermarc
changed the title
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
* fix(exporter-logs-otlp-grpc): set User-Agent header * fix(exporter-logs-otlp-http): set User-Agent header * fix(exporter-logs-otlp-proto): set User-Agent header * chore(changelog): update changelog --------- Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The User-Agent header is set for all log exporters by default
Fixes #4397
Adds the header to node exporters for:
Short description of the changes
The headers have been updated. The headers are overridden by using the spread operator instead of
Object.assignto achieve consistency with exporters of other signals.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: