Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare release 1.20.0/0.47.0 #4382

Conversation

pichlermarc
Copy link
Member

1.20.0

🚀 (Enhancement)

  • perf(otlp-transformer): skip unnecessary base64 encode of span contexts #4343 @seemk
  • feat(sdk-trace-base): improve log messages when dropping span events #4223 @mkubliniak

0.47.0

🐛 (Bug Fix)

@pichlermarc pichlermarc requested a review from a team December 20, 2023 13:41
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Merging #4382 (1f4873f) into main (f4b681d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4382   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         333      333           
  Lines        9459     9459           
  Branches     2009     2009           
=======================================
  Hits         8724     8724           
  Misses        735      735           

@dyladan
Copy link
Member

dyladan commented Dec 20, 2023

@pichlermarc does the IITM fix help the contrib issue? Something you mentioned earlier today made me think you were second-guessing that.

@pichlermarc
Copy link
Member Author

@pichlermarc does the IITM fix help the contrib issue? Something you mentioned earlier today made me think you were second-guessing that.

Yep, I think it may be better to hold off on this release until after the holidays. I think the problems we're having in contrib won't be fixed by updating to 1.7.2.

There the problem is that we use export * to re-export from @opentelemetry/instrumentation-http. This would work in 1.7.2 if it was an ESM module, but since @opentelemetry/instrumentation-http is actually loaded as CJS the re-exports are not working when the import-in-the-middle hook is registered on Node 18.19 and Node 20.

This is only the first problem we encounter it fails at. We have many re-exports using export * and other packages could have that too, so the ESM tests in contrib will likely continue to fail until there's solution in iitm for that.

@trentm
Copy link
Contributor

trentm commented Dec 20, 2023

This is only the first problem we encounter it fails at. We have many re-exports using export * and other packages could have that too, so the ESM tests in contrib will likely continue to fail until there's solution in iitm for that.

I've opened open-telemetry/opentelemetry-js-contrib#1873 to temporarily pin to Node.js v18.18.2 until we can get an IITM fix in.

@pichlermarc pichlermarc marked this pull request as draft December 21, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants