Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node 20 to test matrix #4336

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Add node 20 to test matrix #4336

merged 8 commits into from
Dec 1, 2023

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 30, 2023

Adding node 20 to see what fails in the tooling. Lots of our tooling has been updated since last time I tried this.

All changes previously reviewed in #4295

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #4336 (1447ad5) into main (593d220) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4336      +/-   ##
==========================================
- Coverage   92.29%   92.21%   -0.09%     
==========================================
  Files         330      332       +2     
  Lines        9426     9439      +13     
  Branches     1999     2000       +1     
==========================================
+ Hits         8700     8704       +4     
- Misses        726      735       +9     
Files Coverage Δ
...entelemetry-instrumentation/src/instrumentation.ts 80.00% <100.00%> (ø)
...ntation/src/instrumentationNodeModuleDefinition.ts 14.28% <ø> (ø)
...strumentation/src/instrumentationNodeModuleFile.ts 33.33% <ø> (ø)

... and 1 file with indirect coverage changes

@dyladan
Copy link
Member Author

dyladan commented Nov 30, 2023

@trentm per your question yesterday it seems that the tooling is actually no longer in the way here. Backported fixes from next and it seems like we're all good

@dyladan dyladan marked this pull request as ready for review November 30, 2023 15:08
@dyladan dyladan requested a review from a team November 30, 2023 15:08
Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems that the tooling is actually no longer in the way here

Nice.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@pichlermarc
Copy link
Member

Do we want to add it to the list of officially supported runtimes (in the readme)? 🤔
If so, we may also want to link this issue (#3774) with this PR :)

@dyladan dyladan linked an issue Dec 1, 2023 that may be closed by this pull request
@dyladan dyladan merged commit 6dd075c into open-telemetry:main Dec 1, 2023
20 checks passed
@dyladan dyladan deleted the test-20 branch December 1, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Node.js v20
3 participants